Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SubGHz: Expansion/VGM support #5

Closed
5 tasks done
HaxSam opened this issue Mar 1, 2024 · 1 comment
Closed
5 tasks done

SubGHz: Expansion/VGM support #5

HaxSam opened this issue Mar 1, 2024 · 1 comment
Assignees
@Willy-JL
Labels
bugfix Something isn't working

Comments

@HaxSam
Copy link
Member

HaxSam commented Mar 1, 2024 •
edited by Willy-JL
Loading

Description of the feature you're suggesting.

With the new API in expansion in the merge, it will be possible to use the VGM in SubGHz without any bugs.

Todo is refactoring the GPS usage in SubGHz:

  • Merge the init+start and deinit+stop functions, and in start check for expansion is connected.
  • On app start, it will try to start if baud rate is set, will work only if no expansion is connected.
  • When baud rate changed for GPS in settings, change them and store also start GPS when baud rate was 0/off before only when no expansion is connected.
  • Delete GPS instance only when it got initialized. subghz->gps
  • everywhere else in the app, it might check for baud rate being set in order to display satellite info. Instead, check for GPS being initialized

Anything else?

No response
@Willy-JL Willy-JL self-assigned this Mar 3, 2024
@Willy-JL Willy-JL added the enhancement New enhancement or request label Mar 3, 2024
@Willy-JL Willy-JL moved this to In Progress in Momentum Progress Tracker Mar 3, 2024
@Willy-JL Willy-JL added bugfix Something isn't working and removed enhancement New enhancement or request labels Mar 3, 2024
@Willy-JL Willy-JL changed the title Expansion support in SubGHz SubGHz: Expansion/VGM support Mar 3, 2024
@Willy-JL Willy-JL moved this from In Progress to Next Up in Momentum Progress Tracker Mar 10, 2024
@Willy-JL Willy-JL moved this from Next Up to In Progress in Momentum Progress Tracker Mar 14, 2024
Willy-JL added a commit that referenced this issue Mar 30, 2024
@Willy-JL
SubGHz: Rework GPS as plugin, fix VGM (#5)
ef2c955 
- Streamlined atomic init and deinit
- Load from plugin into RAM dynamically
- Don't attempt load if VGM / Expansion is connected
- Deduplicated some code, cleaned up some other bits
@Willy-JL Willy-JL added the release-pending This is done, will be in next release label Mar 30, 2024
@Willy-JL Willy-JL moved this from In Progress to Done in Momentum Progress Tracker Mar 30, 2024
@Willy-JL
Copy link
Member

Fix was released in mntm-002

@Willy-JL Willy-JL removed the release-pending This is done, will be in next release label May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Willy-JL Willy-JL

Labels
bugfix Something isn't working
Projects
Momentum Progress Tracker
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Willy-JL @HaxSam