Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNTM Pack - Adding NFC emulation & IR remote recording graphic assets #65

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

Kuronons
Copy link
Contributor

@Kuronons Kuronons commented Apr 1, 2024

Yap²

In addtition to yappy insert, edited the IR remote's Flip so it fully displays on screen. (was originally cut on the right side)

Note that NFC pict is 64px high... and is not set properly on y=0.
Managed to fit the drawn part on Flip screen but this could (should?) be code-edited imo... no reason a pict is set to partially display out of the screen.

@Willy-JL
Copy link
Member

Willy-JL commented Apr 2, 2024

Note that NFC pict is 64px high... and is not set properly on y=0.
Managed to fit the drawn part on Flip screen but this could (should?) be code-edited imo... no reason a pict is set to partially display out of the screen

ironically, some of the uses of NFC_dolphin_emulation_51x64 are inside the lfrfid app and are correctly at y=0, theres only on reference in the nfc app, and thats at y=3. i think it should be fine, i get what you mean, but also the default icon touches the edge of the screen at the top, so i guess it was on purpose to have it shifted a bit

thank you! :D

@Willy-JL Willy-JL merged commit 9ce999d into Next-Flip:dev Apr 2, 2024
2 checks passed
@Willy-JL Willy-JL added the enhancement New enhancement or request label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New enhancement or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants