Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding two new .ir files to inflared folder and two new .txt remotes base on those #78

Closed
viralatadr opened this issue Apr 5, 2024 · 5 comments
Labels
question Some information is requested

Comments

@viralatadr
Copy link

viralatadr commented Apr 5, 2024

Describe the enhancement you're suggesting.

Hi, i just recently find and create two new .ir files for two Washlet/Bidet brands and also create two remotes for those file to put in inflared/remote. Is there a way that this could be part of Momentum?

Screenshot-20240405-075555

Screenshot-20240405-075409

Screenshot-20240405-075345

Anything else?

No response

@Willy-JL
Copy link
Member

Willy-JL commented Apr 5, 2024

we don't want to include extra files by default, we are a firmware after all. we only include example files typically, and for ir that is the samsung remote. IIRC this was part of a bounty on our discord, i suggest you share them in the script sharin channel, and maybe contribute to a file dump like uberguidoz'

@Willy-JL Willy-JL closed this as not planned Won't fix, can't repro, duplicate, stale Apr 5, 2024
@Willy-JL Willy-JL added the question Some information is requested label Apr 5, 2024
@viralatadr
Copy link
Author

Got it

@viralatadr
Copy link
Author

I had never done a pull request bofore. Today i did two. It was fun. Thank you for the recomendation. Now lets see if they aprove it.

@viralatadr
Copy link
Author

we don't want to include extra files by default, we are a firmware after all. we only include example files typically, and for ir that is the samsung remote. IIRC this was part of a bounty on our discord, i suggest you share them in the script sharin channel, and maybe contribute to a file dump like uberguidoz'

Did it in the Uberguidoz and logickworkshop repo

@Willy-JL
Copy link
Member

Willy-JL commented Apr 5, 2024

nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Some information is requested
Projects
None yet
Development

No branches or pull requests

2 participants