Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VGM: Custom color options #15

Merged
merged 13 commits into from
Mar 8, 2024
Merged

VGM: Custom color options #15

merged 13 commits into from
Mar 8, 2024

Conversation

HaxSam
Copy link
Member

@HaxSam HaxSam commented Mar 7, 2024 •
edited by Willy-JL
Loading

What's new

  • added the LED RGB property to use it in VGM

For the reviewer

  • I've uploaded the firmware with this patch to a device and verified its functionality
  • I've confirmed the bug to be fixed / feature to be stable

@Willy-JL Willy-JL marked this pull request as ready for review March 8, 2024 02:36
@Willy-JL Willy-JL changed the title VGM: rgb property VGM: Custom color options Mar 8, 2024
@Willy-JL Willy-JL merged commit 8a37dab into dev Mar 8, 2024
4 checks passed
@Willy-JL Willy-JL deleted the rgb_rpc_property branch March 8, 2024 02:38
@Willy-JL Willy-JL added the feature New feature or request label Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Willy-JL Willy-JL Willy-JL approved these changes

@Sil333033 Sil333033 Awaiting requested review from Sil333033 Sil333033 is a code owner

Assignees

@Willy-JL Willy-JL

@HaxSam HaxSam

Labels
feature New feature or request
Projects
Momentum Progress Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HaxSam @Willy-JL