Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NFC: EMV expiry date month bug #289

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

NFC: EMV expiry date month bug #289

wants to merge 1 commit into from

Conversation

Willy-JL
Copy link
Member

@Willy-JL Willy-JL commented Nov 4, 2024 •
edited
Loading

What's new

  • users reported EMV cards showing 00 as expiry date month
  • cannto replicate on my mastercards, they all show day month and year correctly
  • testing revert of 14a layer changes to see if this had side effects in emv parser (relevant commits 0902fd4 and 57c438d)

For the reviewer

  • I've uploaded the firmware with this patch to a device and verified its functionality
  • I've confirmed the bug to be fixed / feature to be stable

@Willy-JL Willy-JL added the bugfix Something isn't working label Nov 4, 2024
@Willy-JL Willy-JL self-assigned this Nov 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024

Compiled f7 firmware for commit 2d62d8a7:

@Willy-JL
Copy link
Member Author

Willy-JL commented Nov 6, 2024

confirmed by @skizzophrenic on discord that reverting this fixes the 00 month issue. however cannot just revert it as this is a major improvement in other areas, so need to investigate why its happening

@Willy-JL Willy-JL added help-wanted Extra attention is needed needs-triage Enough information, needs to be investigated labels Nov 6, 2024
@Willy-JL Willy-JL removed their assignment Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sil333033 Sil333033 Awaiting requested review from Sil333033 Sil333033 will be requested when the pull request is marked ready for review Sil333033 is a code owner

@HaxSam HaxSam Awaiting requested review from HaxSam HaxSam will be requested when the pull request is marked ready for review HaxSam is a code owner

@MatthewKuKanich MatthewKuKanich Awaiting requested review from MatthewKuKanich MatthewKuKanich will be requested when the pull request is marked ready for review MatthewKuKanich is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bugfix Something isn't working help-wanted Extra attention is needed needs-triage Enough information, needs to be investigated
Projects
Momentum Progress Tracker
Status: Next Up
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Willy-JL