Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS: Add widget module #56

Merged
merged 4 commits into from
Mar 28, 2024
Merged

JS: Add widget module #56

merged 4 commits into from
Mar 28, 2024

Conversation

jamisonderek
Copy link
Contributor

What's new

  • Add widget module. The widget module has a bunch of addXXX methods for adding frame, rframe, box, rbox, circle, disc, dot, glyph, icon, line, text and xbm images. Every time you call add, it returns an id that can be used by remove if you want to remove the item later. show() is non-blocking UI, so your JS can do other processing while the UI is displayed. The user can click the back button or you can call close() to dismiss the view.

For the reviewer

  • I've uploaded the firmware with this patch to a device and verified its functionality
  • I've confirmed the bug to be fixed / feature to be stable

@Willy-JL
Copy link
Member

Aside from that single nitpick, this is looking great, thank you so much! This will prove very useful for many scripts.

I can get that small change done tomorrow unless you do it before me 😄

@Willy-JL Willy-JL added the feature New feature or request label Mar 27, 2024
applications/system/js_app/modules/js_widget.c Outdated Show resolved Hide resolved
@Willy-JL Willy-JL merged commit d4e5885 into Next-Flip:dev Mar 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants