Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FindMy Add Ability to Show MAC #58

Merged
merged 3 commits into from
Mar 28, 2024
Merged

FindMy Add Ability to Show MAC #58

merged 3 commits into from
Mar 28, 2024

Conversation

MatthewKuKanich
Copy link
Member

What's new

  • Added show_mac toggle to save state.
  • Reworked GUI logic and formatting
  • Added not just a Yes option but also a No option ;)

For the reviewer

  • I've uploaded the firmware with this patch to a device and verified its functionality
  • I've confirmed the bug to be fixed / feature to be stable

Willy-JL
Willy-JL approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@Willy-JL Willy-JL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :D

@Willy-JL Willy-JL merged commit fc004a6 into dev Mar 28, 2024
3 checks passed
@Willy-JL Willy-JL deleted the findmy-update branch March 28, 2024 21:56
@Willy-JL Willy-JL added the enhancement New enhancement or request label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Willy-JL Willy-JL Willy-JL approved these changes

@Sil333033 Sil333033 Awaiting requested review from Sil333033 Sil333033 is a code owner

@HaxSam HaxSam Awaiting requested review from HaxSam HaxSam is a code owner

Assignees

@MatthewKuKanich MatthewKuKanich

Labels
enhancement New enhancement or request
Projects
Momentum Progress Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatthewKuKanich @Willy-JL