Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expansion: Add is_connected API to check for VGM #6

Merged
merged 6 commits into from
Mar 5, 2024

Conversation

HaxSam
Copy link
Member

@HaxSam HaxSam commented Mar 1, 2024

What's new

  • Added new API to expansion to get the information if an expansion is initialized
  • The expansion_worker communicates back to the control if there is an RPC connection
  • new state for expansion for an established connection

@Willy-JL was heavily involved


For the reviewer

  • I've uploaded the firmware with this patch to a device and verified its functionality
  • I've confirmed the bug to be fixed / feature to be stable

@HaxSam HaxSam mentioned this pull request Mar 1, 2024
5 tasks
@Willy-JL Willy-JL marked this pull request as draft March 3, 2024 07:39
@Willy-JL Willy-JL self-assigned this Mar 3, 2024
@Willy-JL Willy-JL added the enhancement New enhancement or request label Mar 3, 2024
@Willy-JL Willy-JL marked this pull request as ready for review March 5, 2024 22:41
@Willy-JL Willy-JL changed the title Add is_connected api for expansion \w @Willy-JL Expansion: Add is_connected API to check for VGM Mar 5, 2024
@Willy-JL
Copy link
Member

Willy-JL commented Mar 5, 2024

nice :D just made a few changes to naming and fixed some race conditions, thanks!

@Willy-JL Willy-JL merged commit cc98d0d into Next-Flip:dev Mar 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New enhancement or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants