Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] 지하철 검색 UI 제작 및 기능 구현 #75

Merged
merged 10 commits into from
Feb 19, 2024

Conversation

ham2174
Copy link
Collaborator

@ham2174 ham2174 commented Feb 19, 2024

관련 이슈

작업한 내용

  • 지하철 검색 UI를 제작하였습니다.
  • 지하철 검색 기능을 구현하였습니다.
    image

PR 포인트

  • [Feat] 지하철 검색 기능 Data, Domain, Network 구현 #72 해당 PR에서 SubwayRepositoryImpl에 빠져있던 @Inject를 추가하였습니다.
  • FunchTextField에 선언된 내부 에러 캡션을 분리하였습니다. 다시 FunchErrorCaption은 Ui로 분리되어 사용됩니다.
  • ProfileUiModel에 지하철 텍스트 필드 상태와 지하철 리스트를 추가하였습니다.
    • 지하철 텍스트 필드의 상태 : Empty, Error, Success, Typing
  • 3235e84 텍스트 필드 포커스시 발생된 바텀바 오류를 수정하였습니다.

🚀Next Feature

  • 전체 화면 네비게이션 연결

@ham2174 ham2174 added the ham😸 Good for newcomers label Feb 19, 2024
@ham2174 ham2174 requested a review from murjune February 19, 2024 07:52
@ham2174 ham2174 self-assigned this Feb 19, 2024
Copy link
Member

@murjune murjune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿입니다~!! LGTM

@ham2174 ham2174 merged commit b5ee851 into develop Feb 19, 2024
1 check passed
@ham2174 ham2174 deleted the feature/create-search-subway-ui-logic branch February 19, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ham😸 Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] 지하철 검색 기능
2 participants