코스 조회 paging 추가 #65
Merged
코스 조회 paging 추가 #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emost22
reviewed
Feb 12, 2024
| @AuthenticationPrincipal PrincipalDetails userDetails) { | ||
| return BasicResponse.success(courseService.getMemberCourse(userDetails.getUser().getUserId())); | ||
| @AuthenticationPrincipal PrincipalDetails userDetails, | ||
| @RequestParam(value = "page", defaultValue = "0") Integer page, |
There was a problem hiding this comment.
다른건 default가 1인데 얘만 0인 이유가 있을까요?
통일은 1로 하고 page - 1을 넣는 방식이 좋을것 같아요!
Comment on lines
59
to
83
| @GetMapping("/all") | ||
| public BasicResponse<CourseGetResList> getAllCourses( | ||
| @AuthenticationPrincipal PrincipalDetails userDetails) { | ||
| return BasicResponse.success(courseService.getAllCourse(userDetails.getUser().getUserId())); | ||
| @AuthenticationPrincipal PrincipalDetails userDetails, | ||
| @RequestParam(value = "page", defaultValue = "1") Integer page, | ||
| @RequestParam(value = "limit", defaultValue = "10") Integer limit) { | ||
| return BasicResponse.success( | ||
| courseService.getAllCourse(userDetails.getUser().getUserId(), page, limit)); | ||
| } | ||
|
|
||
| @GetMapping("/owner") | ||
| public BasicResponse<CourseGetResList> getOwnedCourses( | ||
| @AuthenticationPrincipal PrincipalDetails userDetails) { | ||
| return BasicResponse.success(courseService.getOwnedCourse(userDetails.getUser().getUserId())); | ||
| @AuthenticationPrincipal PrincipalDetails userDetails, | ||
| @RequestParam(value = "page", defaultValue = "1") Integer page, | ||
| @RequestParam(value = "limit", defaultValue = "10") Integer limit) { | ||
| return BasicResponse.success( | ||
| courseService.getOwnedCourse(userDetails.getUser().getUserId(), page, limit)); | ||
| } | ||
|
|
||
| @GetMapping("/member") | ||
| public BasicResponse<CourseGetResList> getMemberCourses( | ||
| @AuthenticationPrincipal PrincipalDetails userDetails) { | ||
| return BasicResponse.success(courseService.getMemberCourse(userDetails.getUser().getUserId())); | ||
| @AuthenticationPrincipal PrincipalDetails userDetails, | ||
| @RequestParam(value = "page", defaultValue = "0") Integer page, | ||
| @RequestParam(value = "limit", defaultValue = "10") Integer limit) { | ||
| return BasicResponse.success( | ||
| courseService.getMemberCourse(userDetails.getUser().getUserId(), page, limit)); |
There was a problem hiding this comment.
지금 생각해보니 조회 api는 하나로 합칠 수 있을것 같아요
이건 뭐 나중에 리펙토링하는 방향으로 가면 어떨까 싶습니다!
There was a problem hiding this comment.
넵 추후에 시간이 된다면 바꾸겠습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
코스 조회 paging 추가
작업사항
관련 이슈