Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update swagger & blue/green deployment #62

Merged
merged 29 commits into from
Feb 25, 2024
Merged

chore: update swagger & blue/green deployment #62

merged 29 commits into from
Feb 25, 2024

Conversation

songyi00
Copy link
Member

@songyi00 songyi00 commented Feb 25, 2024 •
edited
Loading

Issue Number

close: #61

작업 내역

구현 내용 및 작업 했던 내역

  • swagger example 정리
  • ETF 섹터 추가
  • 블루/그린 배포 적용

변경사항

  • 의존성 목록

PR 특이 사항

PR을 볼 때 주의깊게 봐야하거나 말하고 싶은 점

  • 블루/그린 배포 적용 완료했고 추후 개선점 있으면 디벨롭하면 좋을 것 같습니다 :)

@songyi00 songyi00 requested a review from chominho96 as a code owner February 25, 2024 10:27
@songyi00 songyi00 changed the title chore: update swagger && rollback deploy chore: update swagger & rollback deploy Feb 25, 2024
chominho96
chominho96 approved these changes Feb 25, 2024
View reviewed changes
Copy link
Member

@chominho96 chominho96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제가 실수가 되게 많았네요 🥲 수고하셨습니다!!

...java/nexters/payout/apiserver/dividend/application/dto/response/MonthlyDividendResponse.java
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 이 example이 문제를 일으켰군요 ㅠㅠ

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵👍 example 도 타입에 맞게 써주어야 하는 것 같아요! 그래서 번거로울 것 같아서 그냥 제거해주었습니다!

@songyi00 songyi00 changed the title chore: update swagger & rollback deploy chore: update swagger & blue/green deployment Feb 25, 2024
@songyi00 songyi00 self-assigned this Feb 25, 2024
@songyi00 songyi00 added enhancement New feature or request setting labels Feb 25, 2024
@songyi00 songyi00 merged commit 1b66779 into develop Feb 25, 2024
3 checks passed
@songyi00 songyi00 deleted the feat/#61 branch February 25, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chominho96 chominho96 chominho96 approved these changes

Assignees

@songyi00 songyi00

Labels
enhancement New feature or request setting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] 무중단 배포 고도화
2 participants
@songyi00 @chominho96