From 8a3b7b81a5dc2739670a50b807a0a1975fdde71b Mon Sep 17 00:00:00 2001 From: Unique-Divine Date: Mon, 18 Dec 2023 15:05:15 -0600 Subject: [PATCH] fix(gorleaser-latest): try using dir other than 'dist' since it's gitignored --- .github/workflows/goreleaser-latest.yml | 14 ++++++++++++-- contrib/docker/goreleaser.Dockerfile | 4 ++-- contrib/make/release.mk | 14 +++++++++++++- 3 files changed, 27 insertions(+), 5 deletions(-) diff --git a/.github/workflows/goreleaser-latest.yml b/.github/workflows/goreleaser-latest.yml index 322c2e866..0421501ca 100644 --- a/.github/workflows/goreleaser-latest.yml +++ b/.github/workflows/goreleaser-latest.yml @@ -19,7 +19,7 @@ jobs: - name: Set up Docker Buildx uses: docker/setup-buildx-action@v3 - + - uses: actions/checkout@v4 with: fetch-depth: 0 @@ -37,6 +37,16 @@ jobs: username: ${{ github.actor }} password: ${{ secrets.GITHUB_TOKEN }} + - name: "Move dist to prevent dockerignore" + run: | + echo "dist contents: $(ls dist)" + if [ ! -d "dist" ]; then + echo "❌ expected dist dir to be generated from make release-snapshot" && exit 1 + else echo "dist dir exists as expected." + fi + rm -rf dist-temp + cp -r dist dist-temp + - name: Build and push versioned image uses: docker/build-push-action@v5 with: @@ -44,4 +54,4 @@ jobs: context: . push: true platforms: linux/amd64,linux/arm64 - tags: ghcr.io/nibiruchain/nibiru:latest \ No newline at end of file + tags: ghcr.io/nibiruchain/nibiru:latest diff --git a/contrib/docker/goreleaser.Dockerfile b/contrib/docker/goreleaser.Dockerfile index 6141c9aaa..baac3233e 100644 --- a/contrib/docker/goreleaser.Dockerfile +++ b/contrib/docker/goreleaser.Dockerfile @@ -1,7 +1,7 @@ FROM golang:1.21 AS builder WORKDIR /root -COPY dist/ /root/ +COPY ./dist-temp/ /root/ ARG TARGETARCH RUN if [ "${TARGETARCH}" = "arm64" ]; then \ @@ -17,4 +17,4 @@ RUN apk --no-cache add ca-certificates COPY --from=builder /root/nibid /usr/local/bin/nibid ENTRYPOINT ["nibid"] -CMD [ "start" ] \ No newline at end of file +CMD [ "start" ] diff --git a/contrib/make/release.mk b/contrib/make/release.mk index 8b7289af0..cf9bfe0f4 100644 --- a/contrib/make/release.mk +++ b/contrib/make/release.mk @@ -5,7 +5,17 @@ PACKAGE_NAME := github.com/NibiruChain/nibiru GOLANG_CROSS_VERSION ?= v1.21.5 -release: +verify-dist-temp: + @if [ ! -d "dist-temp" ]; then \ + echo "dist-temp does not exist, please run release-snapshot first"; \ + exit 1; \ + fi + +# The `make release` command is running a Docker container with the image +# `gorelease/goreleaser-cross:${GOLANG_CROSS_VERSION}`. This command: +# `-v "$(CURDIR)":/go/src/$(PACKAGE_NAME)`: mounts the current directory +# `release --rm-dist`: executes the release inside the directory +release: verify-dist-temp docker run \ --rm \ --platform linux/amd64 \ @@ -26,3 +36,5 @@ release-snapshot: -e CGO_ENABLED=1 \ goreleaser/goreleaser-cross:${GOLANG_CROSS_VERSION} \ release --clean --snapshot + rm -rf dist-temp + cp -r dist dist-temp