Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[evm] performance: since we only create a cacheCtx whenever a precompile is called, then reverting a precompile call can just get rid of the cacheCtx and reset the writeToCommitCtxFromCacheCtx function to nil. That would be a cleaner way to revert a PrecompileCalled journal entry rather than deep copy the multistore and save it in a snapshot, but I'd have to test that implementation out. #2099

Open
Unique-Divine opened this issue Oct 29, 2024 · 0 comments
Labels
S-triage Status: This issue is waiting on initial triage. More Info: https://tinyurl.com/25uty9w5

Comments

@Unique-Divine
Copy link
Member

Unique-Divine commented Oct 29, 2024

Note to future self: since we only create a cacheCtx whenever a precompile is called, then reverting a precompile call can just get rid of the cacheCtx and reset the writeToCommitCtxFromCacheCtx function to nil. That would be a cleaner way to revert a PrecompileCalled journal entry rather than deep copy the multistore and save it in a snapshot, but I'd have to test that implementation out.

Originally posted by @k-yang in #2094 (comment)

@github-project-automation github-project-automation bot moved this to ⚡ Building 🧱 in ⚛️ Nibiru (Hougyoku) Oct 29, 2024
@github-actions github-actions bot added the S-triage Status: This issue is waiting on initial triage. More Info: https://tinyurl.com/25uty9w5 label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-triage Status: This issue is waiting on initial triage. More Info: https://tinyurl.com/25uty9w5
Projects
Status: ⚡ Building 🧱
Development

No branches or pull requests

1 participant