[evm] performance: since we only create a cacheCtx
whenever a precompile is called, then reverting a precompile call can just get rid of the cacheCtx
and reset the writeToCommitCtxFromCacheCtx
function to nil
. That would be a cleaner way to revert a PrecompileCalled
journal entry rather than deep copy the multistore and save it in a snapshot, but I'd have to test that implementation out.
#2099
Labels
S-triage
Status: This issue is waiting on initial triage. More Info: https://tinyurl.com/25uty9w5
Note to future self: since we only create a
cacheCtx
whenever a precompile is called, then reverting a precompile call can just get rid of thecacheCtx
and reset thewriteToCommitCtxFromCacheCtx
function tonil
. That would be a cleaner way to revert aPrecompileCalled
journal entry rather than deep copy the multistore and save it in a snapshot, but I'd have to test that implementation out.Originally posted by @k-yang in #2094 (comment)
The text was updated successfully, but these errors were encountered: