From abb6433f506851430dffb66f0dd34c1e70a223fe Mon Sep 17 00:00:00 2001 From: chirag-singhal Date: Tue, 1 Sep 2020 18:45:05 -0700 Subject: [PATCH] Fix RNTester Path (#29786) Summary: * Corrects running on android instructions for rn-tester * Corrects path for rn-tester in package.json, contributing.md and .buckconfig ## Changelog [General] [Fixed] - Fix rn-tester path in documentation and configs Pull Request resolved: https://github.com/facebook/react-native/pull/29786 Reviewed By: hramos Differential Revision: D23441274 Pulled By: rickhanlonii fbshipit-source-id: 9454679335d3794b59a1e4c2e7eae23ed348a427 --- .buckconfig | 2 +- CONTRIBUTING.md | 4 ++-- package.json | 4 ++-- packages/rn-tester/README.md | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.buckconfig b/.buckconfig index dc22ddc157f629..0740647479601e 100644 --- a/.buckconfig +++ b/.buckconfig @@ -11,4 +11,4 @@ jcenter = https://jcenter.bintray.com/ [alias] - rntester = //RNTester/android/app:app + rntester = //packages/rn-tester/android/app:app diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index c8b28345822a18..5aad570ec84190 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -72,12 +72,12 @@ We recommend referring to the [CONTRIBUTING](https://github.com/facebook/react-n ## Contributing Code -Code-level contributions to React Native generally come in the form of [pull requests](https://help.github.com/en/articles/about-pull-requests). These are done by forking the repo and making changes locally. Directly in the repo, there is the [`RNTester` app](/RNTester) that you can install on your device (or simulators) and use to test the changes you're making to React Native sources. +Code-level contributions to React Native generally come in the form of [pull requests](https://help.github.com/en/articles/about-pull-requests). These are done by forking the repo and making changes locally. Directly in the repo, there is the [`rn-tester` app](/packages/rn-tester) that you can install on your device (or simulators) and use to test the changes you're making to React Native sources. The process of proposing a change to React Native can be summarized as follows: 1. Fork the React Native repository and create your branch from `master`. -2. Make the desired changes to React Native sources. Use the `RNTester` app to test them out. +2. Make the desired changes to React Native sources. Use the `packages/rn-tester` app to test them out. 3. If you've added code that should be tested, add tests. 4. If you've changed APIs, update the documentation, which lives in [another repo](https://github.com/facebook/react-native-website/). 5. Ensure the test suite passes, either locally or on CI once you opened a pull request. diff --git a/package.json b/package.json index 98757ed0375887..475f098ac04fe9 100644 --- a/package.json +++ b/package.json @@ -129,7 +129,7 @@ "android.emu.release": { "binaryPath": "packages/rn-tester/android/app/build/outputs/apk/hermes/release/app-hermes-x86-release.apk", "testBinaryPath": "packages/rn-tester/android/app/build/outputs/apk/androidTest/hermes/release/app-hermes-release-androidTest.apk", - "build": "./gradlew :packages:rn-tester:android:app:assembleRelease RNTester:android:app:assembleAndroidTest -DtestBuildType=release", + "build": "./gradlew :packages:rn-tester:android:app:assembleRelease :packages:rn-tester:android:app:assembleAndroidTest -DtestBuildType=release", "type": "android.emulator", "device": { "avdName": "Nexus_6_API_29" @@ -138,7 +138,7 @@ "android.emu.debug": { "binaryPath": "packages/rn-tester/android/app/build/outputs/apk/hermes/debug/app-hermes-x86-debug.apk", "testBinaryPath": "packages/rn-tester/android/app/build/outputs/apk/androidTest/hermes/debug/app-hermes-debug-androidTest.apk", - "build": "./gradlew :packages:rn-tester:android:app:assembleDebug RNTester:android:app:assembleAndroidTest -DtestBuildType=debug", + "build": "./gradlew :packages:rn-tester:android:app:assembleDebug :packages:rn-tester:android:app:assembleAndroidTest -DtestBuildType=debug", "type": "android.emulator", "device": { "avdName": "Nexus_6_API_29" diff --git a/packages/rn-tester/README.md b/packages/rn-tester/README.md index e286de8cb51702..4c9733acf95377 100644 --- a/packages/rn-tester/README.md +++ b/packages/rn-tester/README.md @@ -25,7 +25,7 @@ You'll need to have all the [prerequisites](https://github.com/facebook/react-na Start an Android emulator. cd react-native - ./gradlew :RNTester:android:app:installJscDebug + ./gradlew :packages:rn-tester:android:app:installJscDebug ./scripts/packager.sh _Note: Building for the first time can take a while._