Set RootNodeKind trait in ModalHostViewShadowNode

Summary: Changelog: [internal] `ModalHostViewShadowNode` didn't have `RootNodeKit` trait, therefore `getRelativeLayoutMetrics` was including nodes in ancestors that it shouldn't have. Reviewed By: shergin Differential Revision: D20735801 fbshipit-source-id: 6b81e3b174c2f82e530abc2bca2da8bebc2270b0
NickGerleman · Mar 31, 2020 · c381518 · c381518
1 parent 8d3d8af
commit c381518
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/ReactCommon/fabric/components/modal/ModalHostViewShadowNode.h b/ReactCommon/fabric/components/modal/ModalHostViewShadowNode.h
@@ -27,6 +27,12 @@ class ModalHostViewShadowNode final : public ConcreteViewShadowNode<
                                           ModalHostViewState> {
  public:
   using ConcreteViewShadowNode::ConcreteViewShadowNode;
+
+  static ShadowNodeTraits BaseTraits() {
+    auto traits = ConcreteViewShadowNode::BaseTraits();
+    traits.set(ShadowNodeTraits::Trait::RootNodeKind);
+    return traits;
+  }
 };
 
 } // namespace react