From 714b138ab1fe137b869fc242019d2df13849c22f Mon Sep 17 00:00:00 2001
From: Nick Logozzo <nlogozzo225@gmail.com>
Date: Thu, 17 Oct 2024 10:51:27 -0400
Subject: [PATCH] V2024.10.0

---
 CHANGELOG.md                 | 9 +++++++++
 CMakeLists.txt               | 2 +-
 Doxyfile                     | 2 +-
 manual/README.md             | 9 ++++-----
 src/localization/gettext.cpp | 2 +-
 5 files changed, 16 insertions(+), 8 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 08fc18b..975c2a3 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,14 @@
 # Changelog
 
+## 2024.10.0
+### Breaking Changes
+None
+### New APIs
+None
+### Fixes
+#### Localization
+- Fixed an issue where translated strings did not show UTF-8 characters correctly on Windows
+
 ## 2024.9.2
 ### Breaking Changes
 None
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 1004d64..db21563 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -20,7 +20,7 @@ endif()
 set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} "${CMAKE_SOURCE_DIR}/cmake")
 
 #libnick Definition
-project ("libnick" LANGUAGES C CXX VERSION 2024.9.2 DESCRIPTION "A cross-platform base for native Nickvision applications.")
+project ("libnick" LANGUAGES C CXX VERSION 2024.10.0 DESCRIPTION "A cross-platform base for native Nickvision applications.")
 include(CMakePackageConfigHelpers)
 include(GNUInstallDirs)
 include(CTest)
diff --git a/Doxyfile b/Doxyfile
index e7fa216..69190a8 100644
--- a/Doxyfile
+++ b/Doxyfile
@@ -48,7 +48,7 @@ PROJECT_NAME           = "libnick"
 # could be handy for archiving the generated documentation or if some version
 # control system is used.
 
-PROJECT_NUMBER         = "2024.9.2"
+PROJECT_NUMBER         = "2024.10.0"
 
 # Using the PROJECT_BRIEF tag one can provide an optional one line description
 # for a project that appears at the top of each page and should give viewer a
diff --git a/manual/README.md b/manual/README.md
index 7022e0c..11cf7ba 100644
--- a/manual/README.md
+++ b/manual/README.md
@@ -6,15 +6,14 @@
 
 libnick provides Nickvision apps with a common set of cross-platform APIs for managing system and desktop app functionality such as network management, taskbar icons, translations, app updates, and more.
 
-## 2024.9.2
+## 2024.10.0
 ### Breaking Changes
 None
 ### New APIs
-#### System
-- Added `Nickvision::System::Environment::hasVariable()`
+None
 ### Fixes
-#### System
-- Fixed an issue where Flatpak deployment mode was not correctly detected
+#### Localization
+- Fixed an issue where translated strings did not show UTF-8 characters correctly on Windows
 
 ## Dependencies
 The following are a list of dependencies used by libnick. 
diff --git a/src/localization/gettext.cpp b/src/localization/gettext.cpp
index 25730fb..1a6e247 100644
--- a/src/localization/gettext.cpp
+++ b/src/localization/gettext.cpp
@@ -23,8 +23,8 @@ namespace Nickvision::Localization
             res = res && (wbindtextdomain(s_domainName.c_str(), Environment::getExecutableDirectory().c_str()) != nullptr);
 #else
             res = res && (bindtextdomain(s_domainName.c_str(), Environment::getExecutableDirectory().c_str()) != nullptr);
-            res = res && (bind_textdomain_codeset(s_domainName.c_str(), "UTF-8") != nullptr);
 #endif
+            res = res && (bind_textdomain_codeset(s_domainName.c_str(), "UTF-8") != nullptr);
             res = res && (textdomain(s_domainName.c_str()) != nullptr);
             initialized = true;
             return res;