Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable '#nullable' context #8

Open
henrygab opened this issue Jun 8, 2021 · 0 comments
Open

Enable '#nullable' context #8

henrygab opened this issue Jun 8, 2021 · 0 comments

Comments

@henrygab
Copy link

henrygab commented Jun 8, 2021

Enabling non-nullable reference types requires explicit update to the .csproj file. This is done for backwards-compatibility.

Current compiler warnings

Three files are currently trying to use the non-nullable reference types feature, without the feature actually being enabled. The compiler emits the following warning for each of Enumerate/BlockEnumerator.cs,
Enumerate/MergeEnumerator.cs, and
Enumerate/TableEnumerator.cs:

warning CS8632: The annotation for nullable reference types should only 
                be used in code within a '#nullable' annotations context. 

See C# documentation for details.
See also relevant stackoverflow thread.


Caveats (click to expand)

For most cases, enabling nullable annotations context should be straightforward. However, there are some functions where special annotations are required. These cases are more fully described by the corresponding documentation on migration strategies.


If interested, I am happy to work on preparing a PR to enable this ... just let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant