add check for ivalid var type

NilFoundation · May 3, 2024 · 7b2fe53 · 7b2fe53
1 parent 70c07e1
commit 7b2fe53
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 0 deletions.
diff --git a/include/nil/crypto3/zk/snark/arithmetization/plonk/constraint.hpp b/include/nil/crypto3/zk/snark/arithmetization/plonk/constraint.hpp
@@ -131,6 +131,8 @@ namespace nil {
                                     case VariableType::column_type::selector:
                                         assignment = assignments.selector(var.index);
                                         break;
+                                    default:
+                                        BOOST_ASSERT_MSG(false, "Invalid column type");
                                 }
 
                                 if (var.rotation != 0) {
@@ -169,6 +171,8 @@ namespace nil {
                                     case VariableType::column_type::selector:
                                         assignment = assignments.selector(var.index);
                                         break;
+                                    default:
+                                        BOOST_ASSERT_MSG(false, "Invalid column type");
                                 }
 
                                 if (var.rotation != 0) {

diff --git a/include/nil/crypto3/zk/snark/arithmetization/plonk/table_description.hpp b/include/nil/crypto3/zk/snark/arithmetization/plonk/table_description.hpp
@@ -74,6 +74,10 @@ namespace nil {
                                 return witness_columns + public_input_columns + a.index;
                             case plonk_variable<typename FieldType::value_type>::column_type::selector:
                                 return witness_columns + public_input_columns + constant_columns + a.index;
+                            default:
+                                std::cerr << "Invalid column type";
+                                std::abort();
+                                break;
                         }
                         /* unreachable*/
                         return std::numeric_limits<size_t>::max();

diff --git a/include/nil/crypto3/zk/snark/systems/plonk/placeholder/gates_argument.hpp b/include/nil/crypto3/zk/snark/systems/plonk/placeholder/gates_argument.hpp
@@ -107,6 +107,10 @@ namespace nil {
                                 case polynomial_dfs_variable_type::column_type::selector:
                                     assignment = assignments.selector(var.index);
                                     break;
+                                default:
+                                    std::cerr << "Invalid column type";
+                                    std::abort();
+                                    break;
                             }
 
                             if (var.rotation != 0) {

diff --git a/include/nil/crypto3/zk/snark/systems/plonk/placeholder/lookup_argument.hpp b/include/nil/crypto3/zk/snark/systems/plonk/placeholder/lookup_argument.hpp
@@ -462,6 +462,10 @@ namespace nil {
                                 case DfsVariableType::column_type::selector:
                                     assignment = assignments.selector(var.index);
                                     break;
+                                default:
+                                    std::cerr << "Invalid column type";
+                                    std::abort();
+                                    break;
                             }
 
                             if (var.rotation != 0) {