-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all Yul references in EVM placeholder base #46
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we work with solidity code it's better to do simple math opernation unchecked{}. It decreases gas consumption.
Is it important for starKnet?
I think blob-parsing function is good second step in transpiling this to starknet.
Fist one -- simple math operations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We definitely need something like expmod_static and inversed_static functions in this branch. We cannot run verifier without them. We need to think, what is the best way to do it using pure solidity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to be tested. Good third step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can create a small test for Merkle trees and try to transpile it to CIAIRO.
It's a good small task, that can be done in a rather short time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point for another small test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to be tested
Changes under should not be merged to master.
This pull request removes all yul asm and re-write sections in pure solidity. It also removes asm code which we no
longer refer. The contents of this branch will be used to transpile to cairo using warp.
There are some outstanding functions which need to be written in cairo
field.sol
as the current implementations aresolidity hacks and might have a better implemention/library in cairo.
Due to re-writing in solidity , i am experiencing errors on deployment of the contracts due to contract size limitations/estimations going out of bounds. Thus no testing was possible in this step.