Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Factory Fee #11

Open
0xAleksaOpacic opened this issue Sep 18, 2024 · 0 comments
Open

Enable Factory Fee #11

0xAleksaOpacic opened this issue Sep 18, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@0xAleksaOpacic
Copy link
Collaborator

0xAleksaOpacic commented Sep 18, 2024

✨ Feature Request

Description


In the current implementation, _mintFee is [disabled](https://github.com/NilFoundation/uniswap-v2-nil/blob/main/contracts/UniswapV2Pair.sol#L82).

The reason for this is that the factory can be deployed on another shard, which may cause issues when fetching feeOn from the factory contract.

We need to enable fees, and there are multiple possible implementations to consider:

1. Manually setting feeOn in each pair
2. Creating a gossip mechanism from the factory to update all pairs

We need to adapt:
1. Factory contract
2. Write task for managing fees

Use Case


In Uniswap V2, the feeTo mechanism is included as part of the protocol's ability to capture a portion of the trading fees. While by
default, no fees are collected by Uniswap V2, the feeTo parameter allows the governance or controlling party (e.g., a DAO or
centralized entity) to activate a fee switch in the future.
@0xAleksaOpacic 0xAleksaOpacic added enhancement New feature or request good first issue Good for newcomers labels Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant