Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missed components connections #578

Closed
akokoshn opened this issue Mar 23, 2024 · 1 comment
Closed

Missed components connections #578

akokoshn opened this issue Mar 23, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@akokoshn
Copy link

akokoshn commented Mar 23, 2024

In case of using memory operations like load/store, gep and pointer arithmetic we may miss connections between components (result of the first components no correlate with input of the second one).

Example:

How to fix:

  • *Add check connectness for assign with --check option
  • Make sure that values from internal_storage not passed as component's input:
  • Pointers should not depend on inputs. May be need add check
  • Check connectness of mock up components:
    • bls12_381_paring
    • fp12_multipliction
    • h2c
    • in_g1
    • in_g2
@akokoshn
Copy link
Author

akokoshn commented May 9, 2024

Fixed in #601

@akokoshn akokoshn closed this as completed May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants