Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TODO macros for more convenient aborting #207

Closed
aleasims opened this issue Mar 12, 2024 · 0 comments · Fixed by #208
Closed

Add TODO macros for more convenient aborting #207

aleasims opened this issue Mar 12, 2024 · 0 comments · Fixed by #208
Assignees
Labels
enhancement New feature or request

Comments

@aleasims
Copy link
Contributor

aleasims commented Mar 12, 2024

Right now we have some part of code, which use UNREACHABLE macro to abort because this part was not yet implemented. Is would be nice to have a special macros for these case, because "unreachable" seems to have different semantics.

We can add TODO(msg) macros which will abort the process and print something like:

NOT YET IMPLEMENTED at /path/to/source
    feature X is not yet implemented

Also we can have another macros TODO_WITH_LINK(msg, link), which will also print the link to corresponding issue if one exists. It will increase verbosity even more:

NOT YET IMPLEMENTED at /path/to/source
    feature X is not yet implemented
    Tracking issue: https://github.com/NilFoundation/zkllvm-assigner/issues/...
@aleasims aleasims added the enhancement New feature or request label Mar 12, 2024
@aleasims aleasims self-assigned this Mar 12, 2024
aleasims added a commit that referenced this issue Mar 12, 2024
@aleasims aleasims linked a pull request Mar 12, 2024 that will close this issue
aleasims added a commit that referenced this issue Mar 12, 2024
aleasims added a commit that referenced this issue Mar 13, 2024
aleasims added a commit that referenced this issue Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant