[SyncWith:zkllvm#438] Memory model v2 #199
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
aleasims
added a commit
to NilFoundation/zkLLVM
that referenced
this pull request
Mar 1, 2024
Changes: * Move to memory model v2 (see NilFoundation/zkllvm-assigner#199)
aleasims
force-pushed
the
172-memory-model-v2
branch
from
bbfdf73 to
dafcab1
Compare
aleasims
added a commit
to NilFoundation/zkLLVM
that referenced
this pull request
Mar 1, 2024
Changes: * Move to memory model v2 (see NilFoundation/zkllvm-assigner#199)
aleasims
force-pushed
the
172-memory-model-v2
branch
3 times, most recently
from
171b1e3 to
4145006
Compare
aleasims
force-pushed
the
172-memory-model-v2
branch
from
4145006 to
f619cfe
Compare
|
Tests will be run in sync with other PRs containing |
3 tasks
aleasims
added a commit
to NilFoundation/zkLLVM
that referenced
this pull request
Mar 4, 2024
Changes: * Move to memory model v2 (see NilFoundation/zkllvm-assigner#199)
aleasims
force-pushed
the
172-memory-model-v2
branch
3 times, most recently
from
ba53f46 to
0d78ec1
Compare
aleasims
force-pushed
the
172-memory-model-v2
branch
5 times, most recently
from
31d8ecd to
1a88ca5
Compare
`LayoutResolver` is moved into `mem` module as well. For added implementations some unit tests are added.
This commit contains changes only in assigner itself. Other components are still unmodified, so build will fail.
This commit contains a bunch of similar changes in different files, required to move to new memory.
aleasims
force-pushed
the
172-memory-model-v2
branch
from
1a88ca5 to
316a765
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements new memory model described in RFC: Assigner memory model v2.
Changes made to assigner itself are pretty significant and made in a separate commit. Other commits are organized by files they changed, so they can be reviewed one by one.
Apart from changes related to new memory model, some other tiny changes were made:
return_valuefield to assigner, where the return value of circuit function should be stored at the end of evaluation. I made it withstd::vector<BlueprintFieldType::integral_value>, so non-native fields may be unmarshalled into it and stored as a single value.