Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toml-test valid/float-exponent test fails on Windows #51

Open
kaushalmodi opened this issue Jul 1, 2021 · 1 comment
Open

toml-test valid/float-exponent test fails on Windows #51

kaushalmodi opened this issue Jul 1, 2021 · 1 comment

Comments

@kaushalmodi
Copy link
Member

https://github.com/NimParsers/parsetoml/pull/50/checks?check_run_id=2966348113

FAIL valid/float-exponent
     Values for key 'neg' don't match:
       Expected:     0.03
       Your encoder: 0.030000000000000006

     input sent to parser-cmd:
       lower = 3e2
       upper = 3E2
       neg = 3e-2
       pos = 3E+2
       zero = 3e0
       pointlower = 3.1e2
       pointupper = 3.1E2
       minustenth = -1E-1

     output from parser-cmd (stdout):
       {
         "lower": {
           "type": "float",
           "value": "300.0"
         },
         "upper": {
           "type": "float",
           "value": "300.0"
         },
         "neg": {
           "type": "float",
           "value": "0.030000000000000006"
kaushalmodi added a commit to kaushalmodi-forks/parsetoml that referenced this issue Jul 1, 2021
@kaushalmodi
Skip a test for now; it's failing on Windows
4005ea7 
Ref:
- NimParsers#51
- https://github.com/NimParsers/parsetoml/pull/50/checks?check_run_id=2966348113
kaushalmodi added a commit that referenced this issue Jul 1, 2021
@kaushalmodi
GHA: Enable Go toml-test based test suite (#50)
83de3f3 
* GHA: Set GOPATH

* GHA: Print go version

* GHA: Attempt to fix GOPATH

https://laszlo.cloud/setting-gopath-in-github-actions

* GHA: Attempt 2 to fix GOPATH

https://github.com/golang/go/wiki/SettingGOPATH#go-113

* GHA: Try getting rid of GOPATH

* GHA: Install toml-test

* GHA: Require go version 1.16.5

This was the latest stable go version when this was committed.

* GHA: Fix .yml

* GHA: Specify the version of toml-test to be installed

* GHA: Separate 'uses' and 'run'

Looks like GHA doesn't work if both are in the same yml node.

* GHA: Looks like we do need to set GOPATH

* GHA: Install an older version of toml-test that installs binary

* Update to use tests for TOML 1.0.0

* GHA: Add skips for failing TOML v1.0.0 tests

Ref: #40

* GHA: Disable testing on macos

It fails with these errors:

    go: writing stat cache: mkdir /home/runner: operation not supported
    go: writing stat cache: mkdir /home/runner: operation not supported
    go: downloading github.com/BurntSushi/toml-test v0.1.1-0.20210628215546-8c0aa6d9c74f
    go get github.com/BurntSushi/toml-test/cmd/toml-test@master: mkdir /home/runner: operation not supported
    stack trace: (most recent call last)
    /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/nimblecache-946033505/nimscriptapi_610282258.nim(187, 16)
    /Users/runner/work/parsetoml/parsetoml/parsetoml.nimble(36, 7) run_toml_test_with_skipsTask
    /Users/runner/work/parsetoml/parsetoml/nim/lib/system/nimscript.nim(273, 7) exec
    /Users/runner/work/parsetoml/parsetoml/nim/lib/system/nimscript.nim(273, 7) Error: unhandled exception: FAILED: go get -u -v github.com/BurntSushi/toml-test/cmd/toml-test@master [OSError]

* Add few comments about incompatibility with TOML v1.0.0

* GHA: Disable testing on Windows

* GHA: Get rid of GOPATH dependency

Assumption is that $GOPATH/bin is auto-added to $PATH.

* Skip a test for now; it's failing on Windows

Ref:
- #51
- https://github.com/NimParsers/parsetoml/pull/50/checks?check_run_id=2966348113
@kaushalmodi kaushalmodi mentioned this issue Jul 1, 2021
Open
@PMunch
Copy link
Member

PMunch commented Jul 2, 2021

Weird that it fails on Windows only..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PMunch @kaushalmodi