Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NK_ prefix for MAXIMUM_STR_REPLY_LENGTH and ReadSlot_t #190

Open
robinkrahl opened this issue Sep 23, 2020 · 0 comments
Open

Add NK_ prefix for MAXIMUM_STR_REPLY_LENGTH and ReadSlot_t #190

robinkrahl opened this issue Sep 23, 2020 · 0 comments
Milestone
v4.0

Comments

@robinkrahl
Copy link
Contributor

Currently, all types and functions defined in NK_C_API.h use the NK_ prefix, expect for MAXIMUM_STR_REPLY_LENGTH and ReadSlot_t. They should be renamed with the next breaking release to make the names consistent.
@szszszsz szszszsz added this to the v4.0 milestone Sep 23, 2020
sgued pushed a commit to sgued/libnitrokey that referenced this issue Feb 14, 2022
@robin-nitrokey
Merge pull request Nitrokey#190 from Nitrokey/fetch-update-error-message
210992c 
nk3: Improve error message for fetch-update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.0
Development

No branches or pull requests
2 participants
@robinkrahl @szszszsz