Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release script quoting #32

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Fix release script quoting #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release-script.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@ jobs:
- uses: cachix/install-nix-action@v25
- name: Create draft release
# The script also depends on gh and git but those are both pre-installed on the runner
run: nix-shell -p python3Packages.requests --run "python assemble_installer.py ${{ github.event.inputs.testing_hydra_eval_id }}" -I nixpkgs=channel:nixos-23.11
run: nix-shell -p python3Packages.requests --run 'python assemble_installer.py "${{ github.event.inputs.testing_hydra_eval_id }}"' -I nixpkgs=channel:nixos-23.11
env:
GH_TOKEN: ${{ github.token }}
6 changes: 5 additions & 1 deletion assemble_installer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,11 @@
# string to use latest eval on Hydra
# TODO: using an empty string is not the cleanest
# TODO: print script usage
eval_id = sys.argv[1]
# TODO: argparse or something
if len(sys.argv) < 2:
eval_id = None
else:
eval_id = sys.argv[1]

response = requests.get('https://hydra.nixos.org/jobset/experimental-nix-installer/experimental-installer/evals', headers={'Accept': 'application/json'})
evals = response.json()['evals']
Expand Down
Loading