-
-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nix community values #1541
Add nix community values #1541
Conversation
This is looking great, thank you! The only extra optional thing I'd be interested in is to have anchors that can be clicked and linked to, but I'm not sure how easy that is to implement. Definitely not a blocker though :) I can't merge this myself, but I'm guessing the marketing team will get to this eventually. |
already saw this, but I wanted to test how everything goes layout wise on mobile. Had no time to review yet, but looks good so far. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I finally had some time to review. First of all thank you for helping display these really important guidelines on our homepage. <3
I have two small gripes with the current state, the first one is that the clickable headlines, while pretty cool in function, now break with the rest of the headlines in regards to color and styling. Maybe putting some anchor Icon next to them would fit more in line with the rest of the community page. Secoundly the quotation boxes could use some less padding on mobile, I guess they would still be seen as such and the text can have a bit more breathing room.
Btw. should we maybe just dedicate a dedicated page to the values instead of blowing up the community page? Would be interested to hear your opinion on that. :)
5788a4e
to
a69c66e
Compare
Went ahead and added a dedicated values page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
applied some small tweaks but now its alright, thanks for your contribution and thanks for your patience <3
Thank you, @crertel and @thilobillerbeck! ❤️ |
Small follow-up to #1541 now that the more long-term https://github.com/NixOS/org/blob/main/doc/values.md exists. The intention is that people don't update the values by making a PR to the homepage, but rather the other repo.
Closes #1534 .
This is a first rough cut to get us talking--it wasn't clear to me if @infinisil was suggesting that this be on the community page or merely linked to, so I figured we could try something and see how we felt.