Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break out teams page. #1587

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

crertel
Copy link
Contributor

@crertel crertel commented Nov 20, 2024

Closes #1511.

Quick stab at this, lemme know what you think.

Removed the teams page, which meant a color change for the foundation section:

image

And then the teams page, nice and clean:

image

Larger view:

image

Mobile:

image

@thilobillerbeck
Copy link
Collaborator

What is the practical outcome you want to achieve with this? I mean, yeah, it looks interesting, but now we have another page and the main nav is even larger than before, which now starts to work against the idea of a quick and concise way of navigation.

@crertel
Copy link
Contributor Author

crertel commented Nov 21, 2024

@fricklerhandwerk filed an issue, here's a PR that resolves that issue. If we don't want to do it, that's cool.

The teams stuff is hidden pretty far down in the community section, and the navbar is a little large but also we could probably consider removing some things if that's a concern. Anyways, this is just to get a conversation started.

@fricklerhandwerk
Copy link
Contributor

fricklerhandwerk commented Nov 21, 2024

@thilobillerbeck arguably we could move "Values" into the community page, that would fit thematically. Eventually we should also consolidate everything about events. That section takes a lot of space and is mostly out of date. (related: #1035 (comment)). There's already https://nix.ug/ which does a very good job at keeping information up to date, and could possibly be integrated more into official resources (wdyt @MatthewCroughan?) or at the very least linked to.

@crertel the change looks very good. We can tweak the order later. I don't think the bureaucratic teams should be in the front rows, but that's out of scope here. :)

@fricklerhandwerk
Copy link
Contributor

Please mind, as is, this will break anchor links to the teams section. We have quite a few of them around, I remember running into the problem of that particular one breaking during the rework.

@crertel
Copy link
Contributor Author

crertel commented Nov 27, 2024

Good catch, I'll do a pass on those when I pick this back up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make a separate "Teams" page
3 participants