Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry on certain upstream error codes. #148

Open
MangoIV opened this issue Feb 5, 2025 · 1 comment
Open

Retry on certain upstream error codes. #148

MangoIV opened this issue Feb 5, 2025 · 1 comment

Comments

@MangoIV
Copy link

MangoIV commented Feb 5, 2025

Certain upstream (GitHub API) error codes may warrant a retry. For example 502 Bad Gateway.

I think what would be nice is a two stage process.

  1. the bot sees that it’s been pinged and puts something to indicate that it realised (maybe a ⏱️ reaction)
  2. the bot tries to merge and only if it was successful puts the 🚀 emoji

(1) may be retried in certain scenarios.

@Mic92
Copy link
Member

Mic92 commented Feb 6, 2025

Sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants