less: Fix withSecure regression

NixOS · Oct 29, 2024 · b14efb9 · b14efb9
1 parent cc88a5e
commit b14efb9
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/pkgs/by-name/le/less/package.nix b/pkgs/by-name/le/less/package.nix
@@ -32,11 +32,15 @@ stdenv.mkDerivation (finalAttrs: {
     "man"
   ];
 
-  configureFlags = [
-    "--sysconfdir=/etc" # Look for 'sysless' in /etc
-    (lib.withFeatureAs true "regex" "pcre2")
-    (lib.withFeature withSecure "secure")
-  ];
+  configureFlags =
+    [
+      "--sysconfdir=/etc" # Look for 'sysless' in /etc
+      (lib.withFeatureAs true "regex" "pcre2")
+    ]
+    # Normally we should add `lib.withFeature withSecure "secure"` to configureFlags,
+    # but `--without-secure` does not work as expected in less-668, it enables secure
+    # mode instead, so only add `--with-secure` if enabled.
+    ++ lib.optional withSecure "--with-secure";
 
   strictDeps = true;