-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement new haskell-updates workflow #361143
Comments
I am in favor! |
In the other thread you suggested getting rid of shellsheck:
Given |
It's not a permanent solution, as it would mean enforcing some kind of dependency discipline in nixpkgs. There's really nothing to prevent other projects from depending on Haskell packages. It would be silly if we had to disable e.g. documentation generated using |
Since haskell-updates is based on master, but merges into staging, we need to base it on a merge-base of staging and master. See NixOS#361143. I'm a bit worried that the information GitHub uses for displaying Pull-Requests becomes stale and this will “add” commits to the PR compared to the base anyways. We'll find out, I suppose.
Since haskell-updates is based on master, but merges into staging, we need to base it on a merge-base of staging and master. See NixOS#361143. I'm a bit worried that the information GitHub uses for displaying Pull-Requests becomes stale and this will “add” commits to the PR compared to the base anyways. We'll find out, I suppose.
Since haskell-updates is based on master, but merges into staging, we need to base it on a merge-base of staging and master. See NixOS#361143. I'm a bit worried that the information GitHub uses for displaying Pull-Requests becomes stale and this will “add” commits to the PR compared to the base anyways. We'll find out, I suppose.
Since haskell-updates is based on master, but merges into staging, we need to base it on a merge-base of staging and master. See NixOS#361143. I'm a bit worried that the information GitHub uses for displaying Pull-Requests becomes stale and this will “add” commits to the PR compared to the base anyways. We'll find out, I suppose.
For the discussion that led to this, see #354270.
I think an uncontroversial way forward would be to do the following going forward:
haskell-updates
PRs onmaster
for fast testing on Hydra.haskell-updates
intostaging
as a general rule. Whenstaging-next
is in an early phase we can consider merging it intostaging-next
on a case per case basis.Outstanding tasks to make this happen (not sure if this is exhaustive?!):
staging-next
rotation. Unfortunately, the PR is currently based onstaging
.HACKING.md
.merge-and-open-pr.sh
maintainer scriptperiodic-merge-24h.yml
to merge the merge base ofstaging
andmaster
intohaskell-updates
to preventhaskell-updates
from being ahead ofstaging
. This should be possible with GitHub action's outputs from jobs, but I don't know how it'd precisely work.cc @NixOS/haskell @vcunat @K900
The text was updated successfully, but these errors were encountered: