Using finalAttrs.src.tag breaks if src is overriden to use rev

[Artturin]

error: cannot coerce null to a string: null

Happens in dunst as it now does changelog = "https://github.com/dunst-project/dunst/blob/${finalAttrs.src.tag}/CHANGELOG.md";

The fix is to not use finalAttrs in meta.

https://github.com/nix-community/nixpkgs-wayland/actions/runs/12472468718/job/34811407386#step:5:3478

https://github.com/NixOS/nixpkgs/pull/366584/files#r1896119706

#355973

[philiptaron]

The fix is to not use finalAttrs.src in meta.

Pretty strongly agree with this.

[Atemu]

I think the actual issue is depending on the internals of src at all, no matter the method to access it.

I've elaborated on this in #362692 before.

You should just define a tag and use it in both places; whether that's using finalAttrs, a let binding or whatever.

[ambroisie]

Should the changelog link's semantics be:

• here are the release notes for this (specific) packaged version
• here are the release notes for (any) version

IMO it should be the latter.

[Atemu]

@ambroisie that's a separate discussion for which there already exists a separate issue.

[ambroisie]

Ah, didn't know, will look for it.