-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build failure: octavePackages.ltfat (darwin) #368187
Comments
Thanks for the quick response, and happy holidays. Unfortunately it seems to not work for me. I'm quite a nix noob, but I managed to piece together this let
pkgs = import (fetchTarball "https://github.com/KarlJoad/nixpkgs/archive/octavePackages.ltfat/fix-ld-error.tar.gz") {
config.packageOverrides = pkgs: {
arpack = pkgs.arpack.overrideAttrs (_: { doCheck = false; });
};
};
in pkgs.mkShell {
buildInputs = with pkgs; [ octave octavePackages.ltfat ];
} (now that I'm building from source, arpack seems to fail some post install tests, so I disable them). If I then run I wish I could help more, especially since you don't have a machine available, but I'm not familiar with the octave build system either. Maybe these lines are suspicious?? If you want me to test anything, I'm more than happy, either in this thread or on discord ( |
1 thing to change here, which may fix things (but I seriously doubt). When you are adding packages to an environment for Octave, do not just specify them in the package list. Instead, you need to inform Nix about the Octave packages you want to use so Nix's Octave machinery can install the requested packages in the right spot. (See Nixpkgs' documentation) So your line should be: buildInputs = with pkgs; [ octave.withPackages(ps: with ps; [ ltfat ]) ] That |
Ok thanks, that makes sense. I had to add parens, but I can confirm that let
pkgs = import (fetchTarball "https://github.com/KarlJoad/nixpkgs/archive/octavePackages.ltfat/fix-ld-error.tar.gz") {
config.packageOverrides = pkgs: {
arpack = pkgs.arpack.overrideAttrs (_: { doCheck = false; });
};
};
in
pkgs.mkShell {
buildInputs = with pkgs; [
(octave.withPackages(ps: with ps; [ ltfat ]))
];
} still results in I don't see a difference, but here's the full log when using your branch, for posterity:
|
Yeah, adding bash-5.2$ ls `mkoctfile -p LIBDIR`
octave pkgconfig
bash-5.2$ ls `mkoctfile -p OCTLIBDIR`
liboctave.11.dylib liboctave.dylib liboctave.la liboctinterp.12.dylib liboctinterp.dylib liboctinterp.la oct site Maybe the layout is different on linux? weird. Not sure whether this would be considered an upstream issue |
opened an issue ltfat/ltfat#198 |
I think because octave is compiled with https://savannah.gnu.org/bugs/?55367 says that home-brew used the flag too but it looks like they removed it: here's where it was added to nixpkgs: #83185 (when macOS support added) flag removed from hombrew Homebrew/homebrew-core@a01651b |
build octave without |
I just tested your suggestion @paparodeo, and I also got ltfat building and running. I ran ltfat through its tests (though it is a very small test suite), and things went fine. I'm going to go through and rebuild and test all packages to see if removing |
I just ran In total there were 15 failing tests, most coming from Octave itself. Only 2 tests were from the miscellaneous package.
If someone on aarch64-darwin could run the same tests, that would be great! |
However, "manually" iterating over all tests and testing them sequentially shows significantly more failures, so I am not sure what to make of that. I would appreciate others testing their use-cases against this branch so we/I can investigate. |
I get 0 failures when run on aarch64-darwin outside of the sandbox which I guess is due to sandbox and perhaps just having some dependancies which weren't available in the checkPhase. how do I run the tests for ./result/bin/octave-cli --eval __run_test_suite__
|
If you want to just test a singular package from the shell, you can do: octave-cli --eval 'pkg test $pkg-name' So: octave-cli --eval 'pkg test ltfat' |
|
Steps To Reproduce
nix-shell -p octavePackages.ltfat
Build log
Build Log
Additional context
Metadata
Notify maintainers
@KarlJoad
Note for maintainers: Please tag this issue in your PR.
Add a 👍 reaction to issues you find important.
The text was updated successfully, but these errors were encountered: