Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blockstream-electrs: init at 0.4.1 #299761

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

delta1
Copy link

@delta1 delta1 commented Mar 28, 2024

Description of changes

New package definition for the Blockstream fork of Electrs: https://github.com/Blockstream/electrs

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@FliegendeWurst FliegendeWurst added the 12. first-time contribution This PR is the author's first one; please be gentle! label Oct 29, 2024
Copy link
Member

@FliegendeWurst FliegendeWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not compile, see #332957

hash = "sha256-fQ1CQ+7mZF8zQBkH2ARcjlXuIdI+csSuxMS5ggTVgnA=";
};

LIBCLANG_PATH = "${libclang.lib}/lib";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
LIBCLANG_PATH = "${libclang.lib}/lib";

use rustPlatform.bindgenHook instead

Comment on lines +36 to +42
meta = with lib; {
description = "Blockstream fork of Electrs specialized for high load";
homepage = "https://github.com/Blockstream/electrs";
license = with licenses; [mit];
maintainers = with maintainers; [delta1];
mainProgram = "electrs";
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
meta = with lib; {
description = "Blockstream fork of Electrs specialized for high load";
homepage = "https://github.com/Blockstream/electrs";
license = with licenses; [mit];
maintainers = with maintainers; [delta1];
mainProgram = "electrs";
};
meta = {
description = "Blockstream fork of Electrs specialized for high load";
homepage = "https://github.com/Blockstream/electrs";
license = lib.licenses.mit;
maintainers = with lib.maintainers; [ delta1 ];
mainProgram = "electrs";
};

@sivizius
Copy link
Contributor

Obsolete by #318195

@FliegendeWurst FliegendeWurst added the awaiting_changes (old Marvin label, do not use) label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle! awaiting_changes (old Marvin label, do not use)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants