Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boilr: run nixfmt; fix build #343286

Merged
merged 2 commits into from
Sep 23, 2024
Merged

boilr: run nixfmt; fix build #343286

merged 2 commits into from
Sep 23, 2024

Conversation

Bot-wxt1221
Copy link
Member

@Bot-wxt1221 Bot-wxt1221 commented Sep 20, 2024

Description of changes

Just do some backport for time-rs

Tracking issue: #332957

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from foolnotion September 20, 2024 17:49
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Sep 20, 2024
@foolnotion
Copy link
Contributor

Looks good to me, please squash your commits into one. Unrelated, boilr is broken right now due to PhilipK/BoilR#408

@Bot-wxt1221
Copy link
Member Author

Bot-wxt1221 commented Sep 22, 2024

@foolnotion Upstream doesn't update for so long. The solution now is running it on Xwayland. We just fix ourself by partilly backport from time-rs. I do not think we should squash them into one commit because they are doing different thing.

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Sep 22, 2024
@Aleksanaa Aleksanaa changed the title boilr: run nixfmt; boilr: fix build boilr: run nixfmt; fix build Sep 22, 2024
@Bot-wxt1221 Bot-wxt1221 removed 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Sep 23, 2024
@Aleksanaa Aleksanaa merged commit b66dad7 into NixOS:master Sep 23, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants