Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zine: fix build with rust 1.80+ #348690

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

ghpzin
Copy link
Contributor

@ghpzin ghpzin commented Oct 15, 2024

  • add patch to Cargo.lock after running "cargo update time", updates time crate to 0.3.36 fixing build error on rust 1.80+

Fixes build of zine (fails since 2024-08-14):
https://hydra.nixos.org/job/nixos/trunk-combined/nixpkgs.zine.x86_64-linux
https://hydra.nixos.org/build/274833406
Log:

   Compiling time v0.3.22
error[E0282]: type annotations needed for `Box<_>`
  --> /build/zine-0.16.0-vendor.tar.gz/time/src/format_description/parse/mod.rs:83:9
   |
83 |     let items = format_items
   |         ^^^^^
...
86 |     Ok(items.into())
   |              ---- type must be known at this point
   |
   = note: this is an inference error on crate `time` caused by an API change in Rust 1.80.0; update `time` to version `>=0.3.35` by calling `cargo update`

Tracking rust 1.80 issue:
#332957

(no upstream PR as they do not commit Cargo.lock to repo, it is only present on crates.io and there have not been any updates since July 2023)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

- add patch to Cargo.lock after running "cargo update time",
updates `time` crate to `0.3.36` fixing build error on rust 1.80+
@ghpzin
Copy link
Contributor Author

ghpzin commented Oct 15, 2024

Result of nixpkgs-review pr 348690 run on x86_64-linux 1

1 package built:
  • zine

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Oct 15, 2024
@Artturin Artturin merged commit 14975c9 into NixOS:master Oct 19, 2024
34 checks passed
@ghpzin ghpzin deleted the zine/fix-build-with-rust-1.80 branch October 19, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants