cargo-gra: init at 0.6.0; karlender: 0.9.2 -> 0.10.4, refactor #353793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bot-wxt1221
force-pushed
the
karlender
branch
from
7b25225 to
28621a3
Compare
13 tasks
Bot-wxt1221
force-pushed
the
karlender
branch
2 times, most recently
from
899f7cf to
efa667c
Compare
gepbird
added
the
0.kind: ZHF Fixes
|
Related: #332957 |
gepbird
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Changes LGTM, tested on x86_64-linux!
Maybe it would be easier to keep the cargo-gra init commit in this PR and close #353801?
Yesterday I also attempted to fix it in https://github.com/gepbird/nixpkgs/tree/karlender-fix-build but didn't have time to skip the problematic test and submit it.
I upstreamed this patch in https://gitlab.com/floers/calendar-stuff/karlender/-/merge_requests/43.
|
Superseeds #242295 |
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
labels
wegank
added
the
12.approvals: 1
Bot-wxt1221
force-pushed
the
karlender
branch
from
efa667c to
3368b85
Compare
|
ofborg fails because of cargo-gra. Menthion that we should merge it after #353801 |
wegank
removed
the
12.approvals: 1
|
I actually only rename meta.platform to meta.platforms. It is only a typo fix. |
Bot-wxt1221
changed the title
Bot-wxt1221
force-pushed
the
karlender
branch
from
3368b85 to
5a5f5cb
Compare
|
@gepbird Please review this again. Now I just simply apply patch from your PR. |
Bot-wxt1221
force-pushed
the
karlender
branch
from
5a5f5cb to
226c3d0
Compare
|
@ofborg build karlender |
gepbird
suggested changes
Nov 6, 2024
Bot-wxt1221
force-pushed
the
karlender
branch
from
226c3d0 to
cbe0405
Compare
gepbird
approved these changes
Nov 6, 2024
chuangzhu
reviewed
Nov 6, 2024
wegank
added
the
12.approvals: 1
|
@chuangzhu Done. |
chuangzhu
approved these changes
Nov 6, 2024
chuangzhu
added
12.approvals: 2
ofborg
bot
added
the
11.by: package-maintainer
Bot-wxt1221
force-pushed
the
karlender
branch
from
8301a9b to
9a47d38
Compare
wegank
removed
12.approvals: 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZHF: #352882
We need cargo-gra for build.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.