ponysay: fix SyntaxWarning #357413
Merged
ponysay: fix SyntaxWarning #357413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when running ponysay, you get this warning twice: ``` /nix/store/.../bin/ponysay/balloon.py:43: SyntaxWarning: invalid escape sequence '\-' ``` It is caused by a docstring containing twice the phrase `\-directional`. The fix is just to make it a raw string (replace `'''` with `r'''`).
NixOSInfra
added
the
12. first-time contribution
|
Successfully created backport PR for |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when running ponysay, you get this warning twice:
It is caused by a docstring containing twice the phrase
\-directional.The fix is just to make it a raw string (replace
'''withr''').I created this PR: erkin/ponysay#322. However, the last commit was a year ago, so I don't expect a quick reply.
To test, I just run:
and don't see the warnings.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.