Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k3s_1_31: 1.31.2+k3s1 -> 1.31.4+k3s1 #365873

Merged
merged 1 commit into from
Dec 22, 2024
Merged

k3s_1_31: 1.31.2+k3s1 -> 1.31.4+k3s1 #365873

merged 1 commit into from
Dec 22, 2024

Conversation

rorosen
Copy link
Contributor

@rorosen rorosen commented Dec 17, 2024 •
edited
Loading

https://github.com/k3s-io/k3s/releases/tag/v1.31.4%2Bk3s1

@NixOS/k3s

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: k3s Kubernates distribution (https://k3s.io/) label Dec 17, 2024
@rorosen rorosen added backport release-24.11 Backport PR automatically 6.topic: k3s Kubernates distribution (https://k3s.io/) and removed 6.topic: k3s Kubernates distribution (https://k3s.io/) labels Dec 17, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 17, 2024
@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Dec 17, 2024
wrmilling
wrmilling approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@wrmilling wrmilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 365873

aarch64-linux

✅ 1 package built:
  • k3s (k3s_1_31)

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Dec 18, 2024
@superherointj
Copy link
Contributor

v1.31.4 is out.
https://github.com/k3s-io/k3s/releases/tag/v1.31.4%2Bk3s1

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Dec 20, 2024
@rorosen
Copy link
Contributor Author

rorosen commented Dec 20, 2024

v1.31.4 is out.

They release faster than we can update :D

@superherointj
Copy link
Contributor

CC @marcusramberg

@marcusramberg
Copy link
Contributor

CC @marcusramberg

Shouldn't this pr be updated to latest?

@rorosen rorosen changed the title k3s_1_31: 1.31.2+k3s1 -> 1.31.3+k3s1 k3s_1_31: 1.31.2+k3s1 -> 1.31.4+k3s1 Dec 22, 2024
@rorosen
Copy link
Contributor Author

rorosen commented Dec 22, 2024

Shouldn't this pr be updated to latest?

Yes that makes sense. It is on latest now so we will just skip v1.31.3+k3s1

@marcusramberg
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 365873

aarch64-linux

✅ 1 package built:
  • k3s (k3s_1_31)

@marcusramberg marcusramberg merged commit 350c45d into NixOS:master Dec 22, 2024
39 of 40 checks passed
@nixpkgs-ci
Copy link

nixpkgs-ci bot commented Dec 22, 2024

Backport failed for release-24.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.11
git worktree add -d .worktree/backport-365873-to-release-24.11 origin/release-24.11
cd .worktree/backport-365873-to-release-24.11
git switch --create backport-365873-to-release-24.11
git cherry-pick -x 16be5207b9326b3c3278a101fd57fa8f6d9a0563

@rorosen rorosen deleted the k3s-1.31.3+k3s1 branch December 23, 2024 10:06
@rorosen rorosen mentioned this pull request Dec 23, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wrmilling wrmilling wrmilling approved these changes

@superherointj superherointj superherointj approved these changes

@yajo yajo Awaiting requested review from yajo

@Mic92 Mic92 Awaiting requested review from Mic92

@marcusramberg marcusramberg Awaiting requested review from marcusramberg

@frederictobiasc frederictobiasc Awaiting requested review from frederictobiasc

@euank euank Awaiting requested review from euank

Assignees
No one assigned
Labels
6.topic: k3s Kubernates distribution (https://k3s.io/) 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rorosen @superherointj @marcusramberg @wrmilling @wegank