Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embeddium Options Screen Integration #16

Closed
Nolij opened this issue May 6, 2024 · 4 comments
Closed

Embeddium Options Screen Integration #16

Nolij opened this issue May 6, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Nolij
Copy link
Owner

Nolij commented May 6, 2024

No description provided.

@Nolij Nolij added the enhancement New feature or request label May 6, 2024
@Nolij Nolij added this to the Zume 1.0.0 milestone May 6, 2024
@Nolij Nolij self-assigned this May 6, 2024
@Nolij Nolij closed this as completed Jun 15, 2024
@seriousfreezing
Copy link

It could also be integrated with Sodium (perhaps also with Angelica?). Since in the new versions Sodium already has a version for NeoForge too.

@Nolij
Copy link
Owner Author

Nolij commented Nov 13, 2024

It could also be integrated with Sodium (perhaps also with Angelica?). Since in the new versions Sodium already has a version for NeoForge too.

Sodium: No for several reasons (logical OR; all of these must change for me to consider it):

  1. Sodium provides no (official) options screen API, which means I would need to use a third-party library or mixins to make it work. I don't want to do either of those.
  2. Sodium is not OSS, and given past interactions with its devs I'd rather not find out their opinion of the legality of either method of interacting with their code.
  3. I can't test it without using Sodium, which I don't want to do (see point 4), and I don't (intentionally) ship things I haven't tested.
  4. I don't want to support Sodium as a project.

Angelica: I'll consider it when/if they backport the Embeddium options screen API (and to the best of my knowledge they haven't done that yet), but please open a new issue for that when/if it happens.

@seriousfreezing
Copy link

Okay, fine. But isn't there any other way to have a configuration screen during the game? Like Cloth Config for Fabric users.

@Nolij
Copy link
Owner Author

Nolij commented Nov 13, 2024

Okay, fine. But isn't there any other way to have a configuration screen during the game? Like Cloth Config for Fabric users.

I'm currently looking at options to have one shared cross-platform config screen. As for Cloth Config, I don't want to go through the effort of configuring every option for several different config screen providers on several different versions. Please join the Discord from the README and send a message in there for further discussion on this topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants