-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor compression + advzip re-deflation #7
Conversation
DCO Assistant Lite bot All contributors have read and affirmed the entire contents of the Developer Certificate of Origin. |
I have read, and hereby affirm the entire contents of the Developer Certificate of Origin. |
how fun
and make the regex non-capturing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor changes left. Overall looks good. Thanks a lot for all the work you've put in to this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for enduring my endless nitpicking. I'll test this and merge it (assuming I don't run in to any issues) this evening.
moves all the compression-related stuff to a
buildSrc
file and adds an extra method that uses advzip (if installed) to re-deflate the jar, saving a few extra kilobytes