Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor compression + advzip re-deflation #7

Merged
merged 10 commits into from
Apr 27, 2024
Merged

Conversation

rhysdh540
Copy link
Contributor

moves all the compression-related stuff to a buildSrc file and adds an extra method that uses advzip (if installed) to re-deflate the jar, saving a few extra kilobytes

Copy link

github-actions bot commented Apr 14, 2024

DCO Assistant Lite bot All contributors have read and affirmed the entire contents of the Developer Certificate of Origin.

@rhysdh540
Copy link
Contributor Author

I have read, and hereby affirm the entire contents of the Developer Certificate of Origin.

@rhysdh540 rhysdh540 marked this pull request as ready for review April 14, 2024 19:13
Copy link
Owner

@Nolij Nolij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor changes left. Overall looks good. Thanks a lot for all the work you've put in to this!

@Nolij Nolij assigned Nolij and unassigned Nolij Apr 26, 2024
@rhysdh540 rhysdh540 requested a review from Nolij April 26, 2024 16:20
Copy link
Owner

@Nolij Nolij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for enduring my endless nitpicking. I'll test this and merge it (assuming I don't run in to any issues) this evening.

@Nolij Nolij merged commit ffb5bbc into Nolij:master Apr 27, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants