Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modularize buildSrc #27

Merged
merged 40 commits into from
Nov 10, 2024
Merged

modularize buildSrc #27

merged 40 commits into from
Nov 10, 2024

Conversation

rhysdh540
Copy link
Contributor

@rhysdh540 rhysdh540 commented Nov 7, 2024 •
edited
Loading

  • moves jar compression into separate tasks, which helps speed it up, makes debugging easier, and makes it more cacheable
  • more attempts to improve ci times by caching local .gradle/ and build/ folders
  • also makes smoke testing use maven dependencies (which allows gradle to cache them)

@rhysdh540
fix caching for CompressJarTask
95a4237
@rhysdh540
remove old comments
f243a71
@rhysdh540
remove old comments
d9fb8f9
@rhysdh540
the great rework
744cd62
@rhysdh540
no daemon in ci
a9bede0
@rhysdh540
better caching i hope
6aea316
@rhysdh540
cache build folders
474191e
@rhysdh540
undo the patch thing
cdda047
@rhysdh540
Merge branch 'master' into zumegradle-rewrite
3d6d7e6 
# Conflicts:
#	buildSrc/src/main/kotlin/dev/nolij/zumegradle/JarCompressing.kt
@rhysdh540
only cache regular builds, and maybe make it actually work
2fa2c0e
@rhysdh540
hmm maybe don't setup-java caching
b1577a0
@rhysdh540
Merge branch 'master' into zumegradle-rewrite
e3290b8 
# Conflicts:
#	.github/workflows/build.yml
#	.github/workflows/pull_request.yml
#	build.gradle.kts
#	buildSrc/src/main/kotlin/dev/nolij/zumegradle/JarCompressing.kt
#	gradle.properties
@rhysdh540
change artifact globs
9bab11f
@rhysdh540
post merge fixes and stuff
ac017fb
@rhysdh540
cache based on gradle.properties
cbd422b
@rhysdh540
bump to upload-artifact v4
3344803
@rhysdh540
Merge remote-tracking branch 'upstream/master' into zumegradle-rewrite
8e49298 
# Conflicts:
#	build.gradle.kts
@rhysdh540
merge but correct
ddf649f
@rhysdh540
make smoke testing a real task
ff8b6e3
@rhysdh540
Merge remote-tracking branch 'upstream/master' into zumegradle-rewrite
71bb18a
@rhysdh540
use gradle dependencies
a9e54e7 
I sincerely hope this works
@rhysdh540
upload test results if they fail
dde44f0 
and upload jars anyways
@rhysdh540
use modrinth maven for now since legfab is down
38349eb
@rhysdh540
indent failed tests
463d4d8
@rhysdh540
no
ee76889
@rhysdh540
back to single file
e01acb4 
sadness
@rhysdh540
Merge remote-tracking branch 'upstream/master' into zumegradle-rewrite
ca8baab 
# Conflicts:
#	.github/workflows/build.yml
#	buildSrc/src/main/kotlin/dev/nolij/zumegradle/SmokeTest.kt
Nolij
Nolij reviewed Nov 7, 2024
View reviewed changes
.github/workflows/build.yml Outdated Show resolved Hide resolved
@rhysdh540 rhysdh540 marked this pull request as ready for review November 7, 2024 05:18
@Nolij Nolij merged commit 71fe5b1 into Nolij:master Nov 10, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2024
@rhysdh540 rhysdh540 deleted the zumegradle-rewrite branch November 13, 2024 01:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Nolij Nolij Nolij approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rhysdh540 @Nolij