Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate whethere we can use number for chain_id in N-API #744

Open
Wodann opened this issue Dec 11, 2024 · 1 comment
Open

Investigate whethere we can use number for chain_id in N-API #744

Wodann opened this issue Dec 11, 2024 · 1 comment

Comments

@Wodann
Copy link
Member

Wodann commented Dec 11, 2024

In TS libraries such as ethers, viem, and @ethereumjs/common the chainId variable is represented as a number, whereas EDR uses BigInt.

We should investigate whether we can also use number in the ProviderConfig while maintaining strong typing for chain_id: u64

@Wodann Wodann added this to EDR Dec 11, 2024
@github-project-automation github-project-automation bot moved this to Unconfirmed in EDR Dec 11, 2024
@Wodann Wodann moved this from Unconfirmed to Todo in EDR Dec 11, 2024
@Wodann
Copy link
Member Author

Wodann commented Dec 16, 2024

The type override only changes the generated index.d.ts and doesn't actually change handling of the received type.

This issue is here for tracking by the team. If you know how to resolve the issue, you're welcome to submit an implementation that we can review. If not, we'll investigate it once we have bandwidth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant