Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent tokio runtime from being dropped outside of our control #773

Open
Wodann opened this issue Jan 17, 2025 · 0 comments
Open

Prevent tokio runtime from being dropped outside of our control #773

Wodann opened this issue Jan 17, 2025 · 0 comments

Comments

@Wodann
Copy link
Member

Wodann commented Jan 17, 2025

#771 highlighted the fact that the tokio::Runtime can be dropped outside of our control, even if we have tokio::runtime::Handles that haven't been dropped yet. This resulted in unexpected behaviour when calling synchronisation primitives in our own Drop implementations.

To avoid this, we should ensure that we ourselves can determine when the async runtime is dropped.

This is blocked by a re-design of our async architecture, as we currently are using napi's tokio::Runtime.

@Wodann Wodann added this to EDR Jan 17, 2025
@github-project-automation github-project-automation bot moved this to Inbox in EDR Jan 17, 2025
@Wodann Wodann moved this from Inbox to Blocked in EDR Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Blocked
Development

No branches or pull requests

1 participant