Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TODOs for hardhat-ethers V3 when V3 features are ready #5788

Closed
6 of 8 tasks
ChristopherDedominici opened this issue Sep 27, 2024 · 0 comments · Fixed by #5884
Closed
6 of 8 tasks

TODOs for hardhat-ethers V3 when V3 features are ready #5788

ChristopherDedominici opened this issue Sep 27, 2024 · 0 comments · Fixed by #5884
Assignees
@ChristopherDedominici
Labels
v-next A Hardhat v3 development task
Milestone
Private Alpha

Comments

@ChristopherDedominici
Copy link
Contributor

ChristopherDedominici commented Sep 27, 2024 •
edited
Loading

HardhatEthersSigner

Example project

  • Remove the explanation in the script on how to run hardhat-ethers using a V2 node

hardhat-ethers README

  • Remove the explanation on how to run hardhat-ethers using a V2 node

Tests

Modify tests:

  • add support for hardhat node in tests, search for TODO: enable when V3 is ready

Delete TMP files:

  • delete the run-tests.ts file
  • delete the pnpm test:tmp command
  • update the initializeTestEthers helper function at the path ./test/helpers/helpers.ts
  • move the tests from the test-tmp folder to the test folder and delete the test-tmp folder

Some of these comments have been addressed in this PR: #5884
@ChristopherDedominici ChristopherDedominici added the v-next A Hardhat v3 development task label Sep 27, 2024
@ChristopherDedominici ChristopherDedominici self-assigned this Sep 27, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Hardhat Sep 27, 2024
Merged
@kanej kanej moved this from Backlog to To-do in Hardhat Sep 30, 2024
@kanej kanej added this to the Private Alpha milestone Oct 29, 2024
Merged
@ChristopherDedominici ChristopherDedominici linked a pull request Oct 29, 2024 that will close this issue
Hardhat ethers: enable tests to use V3 node #5884
Merged
@kanej kanej closed this as completed Oct 30, 2024
@github-project-automation github-project-automation bot moved this from To-do to Done in Hardhat Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChristopherDedominici ChristopherDedominici

Labels
v-next A Hardhat v3 development task
Projects
Hardhat
Archived in project
Milestone
Private Alpha
Development

Successfully merging a pull request may close this issue.

Hardhat ethers: enable tests to use V3 node NomicFoundation/hardhat
2 participants
@kanej @ChristopherDedominici