Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDR garbage collection in multi-chain cases #5962

Open
kanej opened this issue Nov 20, 2024 · 0 comments
Open

EDR garbage collection in multi-chain cases #5962

kanej opened this issue Nov 20, 2024 · 0 comments
Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task

Comments

@kanej
Copy link
Member

kanej commented Nov 20, 2024

In Hardhat 3 we can create multiple EDR instances in one execution. We want to ensure we are correctly unallocating resources once an EDR instance is finished with.

We should investigate that EDR instances are being garbage collected when expected and that we free up the resources on the EDR side when this happens. In particular there is a danger that Hook Handlers hold on to instances of EDR if not carefully implemented.

This is a risk now, but also with changes in Hooks in the future. We should implement a harness and regression test that allows us to detect memory leaks around EDR instances.

@kanej kanej added this to the Private Alpha Follow-up milestone Nov 20, 2024
@kanej kanej added the v-next A Hardhat v3 development task label Nov 20, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Hardhat Nov 20, 2024
@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Nov 20, 2024
@kanej kanej moved this from Backlog to To-do in Hardhat Nov 20, 2024
@kanej kanej changed the title EDR garbase collection in multi-chain cases EDR garbage collection in multi-chain cases Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task
Projects
Status: To-do
Development

No branches or pull requests

2 participants