From 3627afcafbf807c2a9bc7bae41cc1ac7f11eafa1 Mon Sep 17 00:00:00 2001 From: Ryuta Kambe Date: Fri, 5 Jul 2024 15:06:44 +0900 Subject: [PATCH] fix(fake_test_node, osqp_interface, qp_interface): remove unnecessary cppcheck inline suppressions (#7855) * fix(fake_test_node, osqp_interface, qp_interface): remove unnecessary cppcheck inline suppressions Signed-off-by: Ryuta Kambe * style(pre-commit): autofix --------- Signed-off-by: Ryuta Kambe Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> --- common/fake_test_node/test/test_fake_test_node.cpp | 4 +--- common/osqp_interface/test/test_osqp_interface.cpp | 1 - common/qp_interface/test/test_osqp_interface.cpp | 1 - common/qp_interface/test/test_proxqp_interface.cpp | 1 - 4 files changed, 1 insertion(+), 6 deletions(-) diff --git a/common/fake_test_node/test/test_fake_test_node.cpp b/common/fake_test_node/test/test_fake_test_node.cpp index 163bd761407c5..77e9294cb48c2 100644 --- a/common/fake_test_node/test/test_fake_test_node.cpp +++ b/common/fake_test_node/test/test_fake_test_node.cpp @@ -96,9 +96,7 @@ TEST_F(FakeNodeFixture, Test) } INSTANTIATE_TEST_SUITE_P( - FakeNodeFixtureTests, FakeNodeFixtureParametrized, - // cppcheck-suppress syntaxError // cppcheck doesn't like the trailing comma. - ::testing::Values(-5, 0, 42)); + FakeNodeFixtureTests, FakeNodeFixtureParametrized, ::testing::Values(-5, 0, 42)); /// @test Test that we can use a parametrized test. TEST_P(FakeNodeFixtureParametrized, Test) diff --git a/common/osqp_interface/test/test_osqp_interface.cpp b/common/osqp_interface/test/test_osqp_interface.cpp index caa89c79d08ea..4644ec6c3e019 100644 --- a/common/osqp_interface/test/test_osqp_interface.cpp +++ b/common/osqp_interface/test/test_osqp_interface.cpp @@ -37,7 +37,6 @@ namespace // y = [-2.9, 0.0, 0.2, 0.0]` // obj = 1.88 -// cppcheck-suppress syntaxError TEST(TestOsqpInterface, BasicQp) { using autoware::common::osqp::calCSCMatrix; diff --git a/common/qp_interface/test/test_osqp_interface.cpp b/common/qp_interface/test/test_osqp_interface.cpp index e5d7041469289..5ce1f0eb064a1 100644 --- a/common/qp_interface/test/test_osqp_interface.cpp +++ b/common/qp_interface/test/test_osqp_interface.cpp @@ -37,7 +37,6 @@ namespace // y = [-2.9, 0.0, 0.2, 0.0]` // obj = 1.88 -// cppcheck-suppress syntaxError TEST(TestOsqpInterface, BasicQp) { using qp::calCSCMatrix; diff --git a/common/qp_interface/test/test_proxqp_interface.cpp b/common/qp_interface/test/test_proxqp_interface.cpp index 96466665d5172..c28678e5c872a 100644 --- a/common/qp_interface/test/test_proxqp_interface.cpp +++ b/common/qp_interface/test/test_proxqp_interface.cpp @@ -38,7 +38,6 @@ namespace // y = [-2.9, 0.0, 0.2, 0.0]` // obj = 1.88 -// cppcheck-suppress syntaxError TEST(TestProxqpInterface, BasicQp) { auto check_result = [](const auto & solution) {