Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taiSeconds should probably be long #564

Open
DomiR opened this issue Aug 10, 2023 · 1 comment
Open

taiSeconds should probably be long #564

DomiR opened this issue Aug 10, 2023 · 1 comment

Comments

@DomiR
Copy link
Contributor

DomiR commented Aug 10, 2023

taiSeconds are 40bits => 5 bytes which means it won't fit into 4 byte int

which means the BitReader should also parse to long

@roshanrajaratnam
Copy link
Member

@DomiR sorry for the delayed reply. Thanks for spotting this. I'll try to find some time to fix this. If you have done already, please do send us a PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants