Feat/use shared 101 (#882)

* Feat: update to shared v101
NordicSemiconductor · Sep 4, 2023 · aacd62d · aacd62d
1 parent dd30b73
commit aacd62d
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 20 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -92,7 +92,7 @@
         }
     },
     "devDependencies": {
-        "@nordicsemiconductor/pc-nrfconnect-shared": "^97.0.0",
+        "@nordicsemiconductor/pc-nrfconnect-shared": "^101.0.0",
         "@playwright/test": "^1.16.3",
         "@testing-library/user-event": "^14.4.3",
         "@types/chmodr": "1.0.0",

diff --git a/src/launcher/features/launcherUpdate/UpdateAvailableDialog.tsx b/src/launcher/features/launcherUpdate/UpdateAvailableDialog.tsx
@@ -6,9 +6,8 @@
 
 import React from 'react';
 import {
-    Button,
     ConfirmationDialog,
-    openUrl,
+    ExternalLink,
 } from '@nordicsemiconductor/pc-nrfconnect-shared';
 
 import { inMain } from '../../../ipc/launcherUpdate';
@@ -38,13 +37,12 @@ export default () => {
                 A new version ({version}) of nRF Connect for Desktop is
                 available. Would you like to update now?
             </p>
-            <Button
-                variant="link"
-                large
-                onClick={() => openUrl(releaseNotesUrl)}
-            >
-                Click to see release notes
-            </Button>
+            <div className="tw-text-sm">
+                <ExternalLink
+                    label="Click to see release notes"
+                    href={releaseNotesUrl}
+                />
+            </div>
         </ConfirmationDialog>
     );
 };
diff --git a/src/launcher/features/launcherUpdate/__snapshots__/UpdateAvailableDialog.test.tsx.snap b/src/launcher/features/launcherUpdate/__snapshots__/UpdateAvailableDialog.test.tsx.snap
@@ -51,14 +51,16 @@ exports[`UpdateAvailableDialog shows the new version if one becomes available  1
             ) of nRF Connect for Desktop is available. Would you like to update now?
           </p>
           <div
-            class="tw-preflight undefined"
+            class="tw-text-sm"
           >
-            <button
-              class="tw-h-8 tw-px-4 tw-text-sm tw-bg-transparent tw-p-0 tw-text-nordicBlue hover:tw-underline"
-              type="button"
+            <a
+              class="tw-preflight tw-text-nordicBlue hover:tw-underline"
+              href="https://github.com/NordicSemiconductor/pc-nrfconnect-launcher/releases"
+              rel="noreferrer noopener"
+              target="_blank"
             >
               Click to see release notes
-            </button>
+            </a>
           </div>
         </div>
         <div