Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved links are not refreshed when target story changes slug #60

Open
didkan opened this issue Jun 28, 2019 · 1 comment
Open

Resolved links are not refreshed when target story changes slug #60

didkan opened this issue Jun 28, 2019 · 1 comment

Comments

@didkan
Copy link
Contributor

didkan commented Jun 28, 2019

Found an issue with how resolve_links: 'url' in sync-stories.js works.
(from commit 946f8e3#diff-8bfd6da487a6a0275e22ffd0b774c74a)

When the story containing the link component (the link story) is published the url of the referenced target story (story to which the link points to) will be resolved and stored. The problem occurs when at a later time the slug of the target story is changed. At that time the stored link will "go stale" but there is no mechanism to trigger a new "resolve-links" call for the link story to update the stored url, resulting in broken links.

We need a way to identify all (link) objects that references the target story so that when it is published we can also mark them as stale or trigger a fetch/update for those objects.

@zimme
Copy link
Contributor

zimme commented Jun 28, 2019

Maybe we shouldn't use resolve link and resolve the links in our extension instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants